docs(live-verify): correct two entries #634 made false, fold in #628-#630/#634 - #636
Merged
Conversation
…630/#634 PR #634 (closes #613) makes two existing entries actively wrong rather than merely stale, which is worse than a gap: a verifier following the old text would read a successful self-heal as a regression. Corrects both, per #635: - The #610 "restart NetworkManager" caveat no longer says the backend probe runs once at startup; it retries while inconclusive. The deferred re-probe gap now points at #633 (the genuinely-unsolved half — switching backends after one is already committed) instead of the closed #613. - The #609 entry no longer expects an `error!` pointing at `systemctl --user restart trollshell` on a transient probe failure. The shipped retry policy is unbounded and self-heals into a `RECOVERED` line instead of giving up. Also folds in the three PRs that merged alongside #634 since the doc's last refresh (#628): - #629 (closes #614): docs/plugin-env.md publishing to the Pages options-doc site, new "Documentation site (GitHub Pages)" section (deploy itself is outside `nix flake check` by design — flagged as a manual check). - #630 (closes #627): modal::close_all's borrow-timing fix, added to Shell chrome as a regression-only check — explicitly states that no observable change is the pass condition. - #634 itself: new Wi-Fi entry covering the INCONCLUSIVE/RECOVERED journal pair and the incidental startup-freeze fix. - #628: docs-only refresh of this file, noted in the closing section. Coverage line bumped to #458 through #634. Documentation-only change. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #635
Documentation-only change —
docs/live-verify.mdonly, no source files touched.Part 1 — correcting the two entries #634 made FALSE (the #635 proper)
:434-437(the fix(network): tell "no link manager" apart from "offline" (#608) #610 "restart NetworkManager" caveat): no longer claims the backend probe runs only once at startup — fix(wifi): retry an inconclusive backend probe instead of latching "no backend" (#613) #634 made it retry while inconclusive. The deferred-gap pointer moved from the now-closed feat(wifi): make backend selection re-entrant so a transient probe failure recovers without a restart (#609 follow-up) #613 to feat(reactive/wifi): switching wireless backend at runtime needs a cancellation primitive that doesn't exist — spawn_supervised returns nothing (#613 phase 2) #633, which is the genuinely-unsolved half (switching backends after one has already been committed and started; blocked on a cancellation primitivespawn_superviseddoesn't have).:463-472(the fix(wifi): a failed backend probe is no longer indistinguishable from "no backend" (#607) #609 entry): no longer tells a verifier to expect anerror!pointing atsystemctl --user restart trollshellon a transient probe failure. The shipped retry policy is unbounded and never gives up, so the correct expected outcome is now a self-heal into awifi: backend probe RECOVEREDline. Following the old text would read a successful recovery as a regression — exactly the failure this document exists to prevent.Part 2 — folding in the four PRs merged since the doc's last refresh
docs/plugin-env.mdnow published on the Pages options-doc site with a real landing page. New "Documentation site (GitHub Pages)" section. The Pages deploy itself is outsidenix flake checkby design, so this is flagged explicitly as a manual post-merge check (site root, both links, table rendering, theplugins.<name>.envdescription linking to the styled page).modal::close_allno longer holds thePANELSborrow acrosswindow.close(). Added to Shell chrome (regression-only). This is a latent-hazard fix with no user-visible change expected, so the entry says plainly that the absence of any observable difference is the pass condition, rather than inventing a ritual that can't fail.INCONCLUSIVE→RECOVEREDlog pair (the log pair is the point, not just the UI outcome). Also notes the incidental startup-freeze fix (the old probe ranrt.block_onon the GTK main thread).Coverage line bumped from
#458 through #625to#458 through #634.Gates
nix fmt— first run touched the file once (a manual line-wrap of mine split a code span across a line break, the known trap), fixed by shortening that span; second and third runs both report 0 files changed.🤖 Generated with Claude Code